search

decaporg / decap-cms

A Git-based CMS for Static Site Generators
https://decapcms.org
MIT License
17.83k stars 3.04k forks source link

Unsolvable Peer Dependency Warning #3828

Open Undistraction opened 4 years ago

Undistraction commented 4 years ago

Yarn gives the following peer-dependency warning when using Redux 4+:

warning "netlify-cms-app > netlify-cms-core > redux-notifications > react-redux@4.4.10" has incorrect peer dependency "redux@^2.0.0 || ^3.0.0".

Looks like redux-notifications has been abandoned and isn't going to update its peer dependency to cover anything later than redux@3 (redux is on 4.0.5 at time of writing).

Latest commit b03011c on 27 Jun 2017

No PR merged since 2108, so I'm guessing the only solution here is to swap out redux-notifications for something else.

Applicable Versions:

Undistraction commented 2 years ago

@erezrokah FYI redux-notifications is now at 4.1.0 and no longer has a peer-dependency on redux. Looks like it would be an easy upgrade.

erezrokah commented 2 years ago

Thanks @Undistraction, I'm no longer maintaining the CMS and will defer to @krider2010

Undistraction commented 2 years ago

Thanks @Undistraction, I'm no longer maintaining the CMS and will defer to @krider2010

Ah. Sorry for the distraction and thanks for your work on Netlify CMS.

erezrokah commented 2 years ago

Thanks ❤️ , I appreciate it (no distraction at all) and feel free to ping me anytime :)

krider2010 commented 2 years ago

Anyone is welcome to open a PR to fix this. Contributions welcome 😄