decaporg / decap-cms

A Git-based CMS for Static Site Generators
https://decapcms.org
MIT License
17.97k stars 3.05k forks source link

Manually commenting `netlify-cms/pending_review` breaks editorial workflow UI #6140

Open calebwilson706 opened 2 years ago

calebwilson706 commented 2 years ago

Describe the bug When you create a post on the cms then comment netlify-cms/pending_review on the bitbucket pr manually it removes the post from the editorial workflow entirely instead of moving it to the correct status

To Reproduce Have editorial workflow turned on (Bitbucket backend) Create a post in netlify cms and save Go to generated PR and comment netlify-cms/pending_review

Behaviour Post no longer shows in editorial workflow

Expected behavior Post should be moved to In Review section in editorial workflow

Screenshots I believe the issue stems from bitbucket escaping the underscore character on user comments Screenshot 2022-01-19 at 17 37 21 This is taken from the debug console in chrome (when the cms auto comments the \\ before _ is not present)

Applicable Versions: netlify-cms-app 2.15.63 netlify-cms-core 2.54.3 netlify-cms 2.10.183

CMS configuration

backend:
  name: bitbucket
  repo: instilco/instil-website
  branch: great-gatsby
  auth_type: implicit
  app_id: PzVBYS6Fsxt9jyeTz4

publish_mode: editorial_workflow
media_folder: "gatsby-instil-website/static/assets/cms-images"
public_folder: "/assets/cms-images"

collections:
  - name: "blog"
    label: "Blog"
    folder: "src/_posts/blog"
    create: true
    slug: "{{year}}-{{month}}-{{day}}-{{slug}}"
    preview_path: "/blog/{{permalink}}"
    fields:
      - { label: "Layout", name: "layout", widget: "hidden", default: "post" }
      - { label: "Title", name: "title", widget: "string" }
      - { label: "Description", name: "description", widget: "string" }
      - { label: "Author", name: "author", widget: "string" }
      - { label: "Permalink", name: "permalink", widget: "string" }
      - { label: "Hook", name: "hook", widget: "string", required: false }
      - { label: "Body", name: "body", widget: "markdown" }
      - {
          label: "Thumbnail",
          name: "thumbnail",
          widget: "image",
          allow_multiple: false,
          required: false
        }
      - {
          label: "Categories",
          name: "categories",
          widget: "list",
          required: false,
          pattern: ['^[a-z]*$', "Category must be lower-case"]
        }
      - {
          label: "Related",
          name: "related",
          widget: "list",
          required: false
        }
      - {
          label: "Image",
          name: "image",
          widget: "image",
          allow_multiple: false,
          required: false
        }
MalikHaroonKhokhar commented 4 months ago

is this still up? would like to work on this issue

MalikHaroonKhokhar commented 4 months ago

@martinjagodic can u assign this issue to me?

philcaz commented 1 month ago

Hi, is this issue still unaddressed? I would like to take this issue

philcaz commented 4 weeks ago

Hi @martinjagodic sorry my group had some difficulty setting up the environment and will have to terminate the assignment. Apologies for the inconvenience