decaporg / decap-cms

A Git-based CMS for Static Site Generators
https://decapcms.org
MIT License
17.83k stars 3.04k forks source link

Gitlab PKCE auth error on Decap 3.1 #7093

Closed kkellydesign closed 7 months ago

kkellydesign commented 7 months ago

As of the Decap 3.1 release on February 1, Gitlab PKCE is no longer working. I've tested both Firefox and Chrome.

When I visit /admin and try to log in, it immediately redirects me to Gitlab and shows the following screen:

Screenshot 2024-02-06 at 12 16 40 PM

To Reproduce config.yml:

backend:
  name: gitlab
  repo: my_repo # Path to your GitHub repository
  auth_type: pkce
  branch: main
  app_id: my_id

admin/index.html – the link below causes the error. But changing the pinned version to 3.1.0-beta.2 fixes it.

     <script src="https://unpkg.com/decap-cms@3.1.1/dist/decap-cms.js"></script>

    <script src="/dist/js/nunjucks-slim.js"></script>
    <script src="/admin/util-bundled.js"></script>
    <script src="/admin/templates.js"></script>
    <script src="/admin/previews.js" type="text/babel"></script>

Applicable Versions:

blackb1rd commented 7 months ago

I suspected https://github.com/decaporg/decap-cms/pull/7014 break gitlab PKCE.

demshy commented 7 months ago

Closed by automation - please test and reopen if patch 3.1.2 does not fix this. Thanks @blackb1rd