decaporg / decap-cms

A Git-based CMS for Static Site Generators
https://decapcms.org
MIT License
17.65k stars 1 forks source link

UI Bug with Media Header Button #7208

Closed camdenvaughan closed 4 days ago

camdenvaughan commented 1 month ago

Describe the bug

After Clicking the "Media" Header link and closing the Media library, the button remains in a colored focus state until anything else on the page is interacted with, it then loses that focus tag and goes back to normal. I have fixed the problem and will follow this bug report with a pull request.

To Reproduce

  1. Open any Decap Dashboard (This works on the interactive Demo)
  2. Click the "Media" Header Link
  3. Click the top left "X" to close the media library
  4. Observe that both the "Content" link and "Media" link are blue
  5. Click anywhere and the "Media" link will return to normal.

Expected behavior

The "Media" link remains gray after interaction.

Screenshots

image

Applicable Versions:

CMS configuration

backend: name: test-repo

site_url: https://example.com

publish_mode: editorial_workflow media_folder: assets/uploads

collections: # A list of collections the CMS should be able to edit

Additional context

The AppHeaderButton style needs to be changed to use :focus-visible instead of :focus