decaporg / gatsby-starter-decap-cms

Example Gatsby + Decap CMS project
https://gatsby-netlify-cms.netlify.app/
MIT License
2.07k stars 979 forks source link

Linting to help contribution #75

Open leptest opened 6 years ago

leptest commented 6 years ago

Suggestion: Adopt popular community configs and common linting tasks.

Why: To help others when contributing to and integrating this project.

How: Use eslint, prettier, stylelint, and/or an editorconfig. Most of these have a popular community config that could be adopted.

Info: Related: https://github.com/AustinGreen/gatsby-starter-netlify-cms/pull/67/ https://github.com/AustinGreen/gatsby-starter-netlify-cms/pull/68/ Semi related: https://github.com/AustinGreen/gatsby-starter-netlify-cms/pull/71 https://github.com/AustinGreen/gatsby-starter-netlify-cms/pull/74 https://github.com/AustinGreen/gatsby-starter-netlify-cms/issues/73 (the semi related ones would have been caught/fixed by using a standard config)

You mentioned in https://github.com/AustinGreen/gatsby-starter-netlify-cms/issues/57 about certain things being removed when a developer forks the project, and i agree this would fall in that category. But i think they are important when contributing to this project.

What are your thoughts?

ekoeryanto commented 6 years ago

One more reason, developer who knows more than 1 programing language or framework use IDE as a (super hero) helper of remembering the API. I do, the same, and I hate that when I see zigzag red lines below the texts when I am writing 🔢

leptest commented 6 years ago

We could also just use the same configs as https://github.com/netlify/netlify-cms or https://github.com/gatsbyjs/gatsby?