Closed ryansb closed 10 years ago
@ryansb I think the change you suggested would fit well into the code. I also know that it would help clean up some more "sloppy" lines of code I was forced to write. students[0]['key'] = value
just doesn't feel right.
I'm going to work on the new structure (for now without your suggestion since I should be able to add that in at the end pretty easily).
@decause what are your thoughts on making the YAML files each simply a dictionary?
+1 to simple dictionary. Originally the .yaml was adapted from a giant .yaml file of all the students in one place. I had a feeling I could have removed at least one layer of nesting, but never got around to it.
Simple dictionary yes.
On Tue, Aug 12, 2014 at 3:05 PM, Liam Middlebrook notifications@github.com wrote:
@ryansb https://github.com/ryansb I think the change you suggested would fit well into the code. I also know that it would help clean up some more "sloppy" lines of code I was forced to write. students[0]['key'] = value just doesn't feel right. I'm going to work on the new structure (for now without your suggestion since I should be able to add that in at the end pretty easily).
@decause https://github.com/decause what are your thoughts on making the YAML files each simply a dictionary?
— Reply to this email directly or view it on GitHub https://github.com/decause/hflossk/issues/418#issuecomment-51961581.
Remy DeCausemaker Assistant Director Lab for Technological Literacy http://foss.rit.edu
Rochester Institute of Technology Center for Student Innovation 159 Lomb Memorial Drive Building 87-1680 Rochester, NY 14623
See #421
Closing this out, new yaml format merged in.
Current YAML:
New yaml suggested by @liam-middlebrook in #416
I like this change, but I have a couple suggestions.
First, the format extracts as
[{"blog": "...", "otherthing": "...}]
. I'd like to get rid of theAnd instead just have the format extract as a dictionary like
{"blog": "...", "name": "...."}
As an added bonus, every line wouldn't need a 2-space indentation.