search

decause / hflossk

HFOSS + Flask = hflossk
Apache License 2.0
38 stars 70 forks source link

Cleaning up some logic #572

Closed msoucy closed 9 years ago

msoucy commented 10 years ago

Updated a docstring, made some cleaner style choices, fixed some person lookup logic.

liam-middlebrook commented 10 years ago

lgtm :thumbsup:

ryansb commented 10 years ago

Can you maybe write a test to verify your changes? I know there wasn't one before, but it'd be great to improve our test coverage.

msoucy commented 9 years ago

The nature of this section of code means that tests would rely on specific users being lookup-able...so, tests are POSSIBLE, though I wouldn't quite say practical.

msoucy commented 9 years ago

Aaaaaaaand wrong button.

ryansb commented 9 years ago

:+1:

decause commented 9 years ago

/me merges patch and opens a new tab to: http://butt.holdings/