search

decent-chat / decent

Open source messaging platform for the modern web
https://meta.decent.chat
GNU General Public License v3.0
21 stars 5 forks source link

External URL profile pictures #224

Open towerofnix opened 6 years ago

towerofnix commented 6 years ago

There should be a way to set your profile picture to an external URL.

However, we have to consider security -- if somebody sets their profile picture to the URL of a server they're running, they could find out the IP addresses of people who view their profile picture (so, anybody in the chat room). Perhaps a client setting to load or not load external profile pictures? But in that case, it also makes sense to have a list of whitelisted domains, and Hmmmmmmmmmmmmmmmmmmmmmm feature creep???

Ping @eq.

ghost commented 6 years ago

yeah it might be feature creep? i dunno the suggestion was a joke lol

ghost commented 6 years ago

the first thing i'm going to do if this gets implemented is set the url to https://eq.ed1.club/spark.png

towerofnix commented 6 years ago

Alternatively, uploading profile pictures straight to Decent.

ghost commented 6 years ago

Well, that's how a lot of services do it, with a fall back to libravatar at least. It makes sense, and I can still upload spark.png

bates64 commented 6 years ago

Uploading direct sounds good. I don't like the idea of arbitrary URLs, though. @eq how do we prevent against spark.png :package: