decent-chat / decent

Open source messaging platform for the modern web
https://meta.decent.chat
GNU General Public License v3.0
21 stars 5 forks source link

Implement pinned messages + message deletion #255

Closed bates64 closed 6 years ago

bates64 commented 6 years ago

@PullJosh did a design for tabs in the right sidebar; this is it in fruition!

towerofnix commented 6 years ago

Pre-code-review notes:

Note - trying to view the "pins" tab while no channel is selected causes an error, because it fetches /api/channels/undefined/pins. Pins tab should probably be hidden while not actively in a channel? (And should switch to "users" tab when going back to a state with no channel active.)

Note - it's sorta hard to tell exactly what message my mouse is on top of, since the icons appear so far to the right. Maybe a dotted line from the message icons to the first line of the related message would help?

Note - on an authorized server, when I reloaded the page, there was an "authorization related error", but I'm 60% sure that doesn't have anything to do with this.

Note - flairs don't show up on pinned messages. I assume this is intentional? (It looks better without flairs imo.)

Note - the most recently pinned messages show up at the bottom of the pinned message list. IMO there should be a way to sort pinned messages - maybe even manually. Otherwise, they should probably be sorted by date. (Should the newest messages go on the top or the bottom?)

Note - the highlight from jumping to a pinned message doesn't look any different in the dark mode, but this is probably fine.

bates64 commented 6 years ago

Hold on, just adding that dotted line thing you asked for.