Closed mudrila closed 1 year ago
This PR should include some (basic) tests as well to confirm that proposals created through this new function can be successfully executed. Let me know if you want / need any help on those!
Yessir - definitely will come with tests. Just wanted to align on implementation first
Comparisons of gas fee for different cases:
Comparison of finalized implementation for submitProposal
and submitProposalWIthMetaData
Comparison of submitProposalWithMetaData
without emitting ProposalMetaDataCreated
Comparison of submitProposal
with submitProposalWithMetaData
with 10 transactions
cc @herbig
This PR implements following:
FractalUsul
contract, which extends from originalUsul
. This contract containssubmitProposalWithMetaData
which will be used instead of originalsubmitProposal
.ProposalMetadataCreated
withproposalId
,title
,description
anddocumentationUrl
transactions
underProposal
struct during proposal creation, but also it convertstransactions
totxHashes
and stores them as well for backwards compatibility with the rest ofUsul
code.Closes #7