decentdao / decent-contracts

Your Safe, Superpowered
https://app.fractalframework.xyz
MIT License
3 stars 3 forks source link

ERC721 Freeze Voting Difference #76

Closed Da-Colon closed 1 month ago

Da-Colon commented 5 months ago

If the dApp we are interacting with the ERC721 contract differently when calling castFreezeVote. Typescript prevents doing it off the contract. We should update this for consistency

 if (freezeVotingContract) {
          if (
            freezeVotingType === FreezeVotingType.MULTISIG ||
            freezeVotingType === FreezeVotingType.ERC20
          ) {
            (freezeVotingContract as ERC20FreezeVoting | MultisigFreezeVoting).castFreezeVote();
          } else if (freezeVotingType === FreezeVotingType.ERC721) {
            getUserERC721VotingTokens(undefined, parentAddress).then(tokensInfo => {
              const freezeERC721VotingContract = baseContracts?.freezeERC721VotingMasterCopyContract.asSigner;
              return freezeERC721VotingContract[
                'castFreezeVote(address[],uint256[])'
              ](tokensInfo.totalVotingTokenAddresses, tokensInfo.totalVotingTokenIds);
            });
          }
        }
adamgall commented 1 month ago

Stale, closing