search

decentdao / decent-contracts

Your Safe, Superpowered
https://app.fractalframework.xyz
MIT License
3 stars 3 forks source link

Update published file #99

Closed Da-Colon closed 1 month ago

Da-Colon commented 1 month ago

Update published file to just be a javascript file.

Da-Colon commented 1 month ago

Whats the publishing workflow? the update package file isn't for bumping to next version. Do you open another PR to do that? or what? @adamgall

adamgall commented 1 month ago

@Da-Colon gotta manually create a new Release on GitHub.

Start with creating a tag and pushing it, then create a Release based on that tag.

The new Release triggers the npm publish.

Da-Colon commented 1 month ago

So I bump the version in this PR then?

adamgall commented 1 month ago

Oooh sorry I get what you're saying. Since this is in a PR, no. Let's bump the version and tag it directly on develop after this is merged.

If you want to test this out before merging, then ignore what I said above and feel free to bump and tag on this PR.

I'm not going to be too picky about tags it in this repo, it's cool.

Da-Colon commented 1 month ago

@adamgall After looking at it again, I think we need to try the typescript route. because of the as const (and not allowed in javascript) allowing for the type to be inferred in the frontend.

adamgall commented 1 month ago

@adamgall After looking at it again, I think we need to try the typescript route. because of the as const (and not allowed in javascript) allowing for the type to be inferred in the frontend.

ooooo yeah good point