decentdao / decent-interface

Govern at startup speed
https://app.decentdao.org
MIT License
14 stars 7 forks source link

Delegate vote 'number' as string?? #1830

Closed tomstuart123 closed 5 months ago

tomstuart123 commented 5 months ago

Image

See above. When I delegated a token to another (1000).. but then received more token from someone else (100), the tokens seemed to bolt on to create 100100... instead of the desired 1100

My guess is we handle them as strings post calculation

Da-Colon commented 5 months ago

Weird...this shouldn't happen there isn't any 'adding' going on. We re-request the balanceOf when an event happens

adamgall commented 5 months ago

@tomstuart123 adding re-skin label

Da-Colon commented 5 months ago

Will need to ssee this one live I think to see whats going on, can't replicate locally.

tomstuart123 commented 5 months ago

lets tackle the other stuff I'm facing first. We can leave this in backlog as a nice to have.

Moving to p2 for now as its an edge case of multiple delegations

adamgall commented 5 months ago

@tomstuart123 can you point to the transactions onchain that led to this scenario in Decent UI?

Ideally I'd like to see the transactions which:

tomstuart123 commented 5 months ago

will do. This might take a while so - if okay - I'll wait to do this until we make our way through the other p1s. want to unblock those first and keep testing pre launch tomorrow

adamgall commented 5 months ago

@tomstuart123 the reason i'm asking you is because i couldn't find those presumed transactions onchain myself.

what you're describing is pretty strange behavior, so i just wanted to see what the data for this issue looks like onchain. it's not clear to me from the original description which addresses were involved in this issue, or the order that steps were taken.

so really, i'm questioning whether the issue is with our app, or something else. the data onchain don't lie

tomstuart123 commented 5 months ago

makes sense. When I have time I'll look at it and share more details of the onchain stuff

adamgall commented 5 months ago

@tomstuart123 i'm going to close this, please re-open if you're able to reproduce