decentdao / decent-interface

Govern at startup speed
https://app.decentdao.org
MIT License
14 stars 7 forks source link

`[roles-0.1.0]` Root #2045

Closed adamgall closed 2 months ago

netlify[bot] commented 3 months ago

Deploy Preview for decent-interface-dev ready!

Name Link
Latest commit 98df40d7e3ea7dcd8d31dd8c987acfec553c8cab
Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/668d4b24d6323700085518eb
Deploy Preview https://deploy-preview-2045.app.dev.decentdao.org
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tomstuart123 commented 2 months ago

Awesome work devs. I was able to complete the whole process on this Safe for mobile - https://deploy-preview-2045.app.dev.decentdao.org/roles?dao=sep:0x40C6E5eFCE3b1f101bFB59e876F14aa5455D3E19

@Da-Colon / @adamgall - few bits of feedback.

1) once you create a role and you get taken back to the edit role page, the 'you haven't created any roles' should disappear Screenshot 2024-07-05 at 16 40 42

2) after I created a proposal, the pending proposal toast came up correctly but I wasn't taken to the proposal list page Screenshot 2024-07-05 at 16 51 46

3) I didn't catch it on video but the role loading icon when you navigate to the roles page and the roles are loading makes the whole component move up and down as it loads (i.e. like this used to be for hierarchy before we fixed it)

4) finally, when the proposal is created, clicking to view the roles didn't really work, video below. This probably is known but just highlighting https://decentdao.slack.com/archives/C06QZTUTKRC/p1720195880327889?thread_ts=1720195806.247159&cid=C06QZTUTKRC

Da-Colon commented 2 months ago

Awesome work devs. I was able to complete the whole process on this Safe for mobile - https://deploy-preview-2045.app.dev.decentdao.org/roles?dao=sep:0x40C6E5eFCE3b1f101bFB59e876F14aa5455D3E19

@Da-Colon / @adamgall - few bits of feedback.

  1. once you create a role and you get taken back to the edit role page, the 'you haven't created any roles' should disappear Screenshot 2024-07-05 at 16 40 42
  2. after I created a proposal, the pending proposal toast came up correctly but I wasn't taken to the proposal list page Screenshot 2024-07-05 at 16 51 46
  3. I didn't catch it on video but the role loading icon when you navigate to the roles page and the roles are loading makes the whole component move up and down as it loads (i.e. like this used to be for hierarchy before we fixed it)
  4. finally, when the proposal is created, clicking to view the roles didn't really work, video below. This probably is known but just highlighting https://decentdao.slack.com/archives/C06QZTUTKRC/p1720195880327889?thread_ts=1720195806.247159&cid=C06QZTUTKRC
  1. Will Update
  2. Will Update
  3. Yep on the list
  4. This one should be fixed in lastest PR #2081