Closed adamgall closed 2 months ago
Awesome work devs. I was able to complete the whole process on this Safe for mobile - https://deploy-preview-2045.app.dev.decentdao.org/roles?dao=sep:0x40C6E5eFCE3b1f101bFB59e876F14aa5455D3E19
@Da-Colon / @adamgall - few bits of feedback.
1) once you create a role and you get taken back to the edit role page, the 'you haven't created any roles' should disappear
2) after I created a proposal, the pending proposal toast came up correctly but I wasn't taken to the proposal list page
3) I didn't catch it on video but the role loading icon when you navigate to the roles page and the roles are loading makes the whole component move up and down as it loads (i.e. like this used to be for hierarchy before we fixed it)
4) finally, when the proposal is created, clicking to view the roles didn't really work, video below. This probably is known but just highlighting https://decentdao.slack.com/archives/C06QZTUTKRC/p1720195880327889?thread_ts=1720195806.247159&cid=C06QZTUTKRC
Awesome work devs. I was able to complete the whole process on this Safe for mobile - https://deploy-preview-2045.app.dev.decentdao.org/roles?dao=sep:0x40C6E5eFCE3b1f101bFB59e876F14aa5455D3E19
@Da-Colon / @adamgall - few bits of feedback.
- once you create a role and you get taken back to the edit role page, the 'you haven't created any roles' should disappear
- after I created a proposal, the pending proposal toast came up correctly but I wasn't taken to the proposal list page
- I didn't catch it on video but the role loading icon when you navigate to the roles page and the roles are loading makes the whole component move up and down as it loads (i.e. like this used to be for hierarchy before we fixed it)
- finally, when the proposal is created, clicking to view the roles didn't really work, video below. This probably is known but just highlighting https://decentdao.slack.com/archives/C06QZTUTKRC/p1720195880327889?thread_ts=1720195806.247159&cid=C06QZTUTKRC
✅ Deploy Preview for decent-interface-dev ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.