search

decentraland / adr

Architecture Decisions Records
https://adr.decentraland.org/
Other
22 stars 11 forks source link

Collision masks for visible and invisible meshes of GLTF component #225

Closed AN-DCL closed 1 year ago

AN-DCL commented 1 year ago

https://github.com/decentraland/protocol/pull/140

cloudflare-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5a5ab8
Status: ✅  Deploy successful!
Preview URL: https://fb2c36dd.adr-cvq.pages.dev
Branch Preview URL: https://gltf-collision-masks.adr-cvq.pages.dev

View logs

slezica commented 1 year ago

The new approach is cleaner, easier to explain and reason about. I think this is a good change.

A thought on the potential performance problem: explorers could have a warning about the scene being especially costly, which (with careful design) would serve two purposes:

  1. When the scene author tests their work, they will see the warning. It could have a link (for example, "I am the scene creator") to a page with performance recommendations, including how to fix this exact problem. We could even have names or codes for specific problems the explorer can diagnose, and the link could take you straight there.

  2. When players see the warning, they'll know that it's a particular scene that's causing problems, and that they can just leave to restore high performance. It can combat the impression that Decentraland as a whole is slow and clunky.