search

decentraland / bronzeage-node

DEPRECATED: This codebase will not be mantained anymore, and formats are going to change when we move to the Decentraland Iron Age
https://decentraland.org
Other
104 stars 22 forks source link

When installing npm modules put them into package.json to reduce number of commands? #53

Closed stefek99 closed 7 years ago

stefek99 commented 7 years ago

Currently:

npm install
npm install bn.js elliptic mkdirp webtorrent-hybrid create-torrent parse-torrent socket.io-client leveldown express cors

It should be possible to change package.json and do the same with the lower number of clicks?

HPrivakos commented 7 years ago

It's already in the package.json =)

stefek99 commented 7 years ago

I see... I'm just a human, when I see "Getting Started" instructions I do not overthink too much.

ghost commented 7 years ago

Hi guys - I added these to the Windows instructions in my PR #46 to add Windows support yesterday. Did it because the npm install for whatever reason didn't install all required modules. I've also seen this on Linux.

Not sure how to fix that but figured it's better-than-nothing to have it in the docs. So at least you can handle it in the install process rather than hitting errors later and needing to fix them.

I agree this should be fixed so npm install handles everything.

stefek99 commented 7 years ago

Did it because the npm install for whatever reason didn't install all required modules.

I'll make the effort to open my Windows laptop and try it out.

martriay commented 7 years ago

@stefek99 could you reproduce this?

stefek99 commented 7 years ago

@martriay

This is my work machine with old node and no python... Super busy, I won't be able to access my Windows laptop at least till Monday.

(I'll try to set up a VM)

image

HPrivakos commented 7 years ago

Read the README, node v7 required

https://github.com/decentraland/bronzeage-node#run-a-node-manually-on-linux

Install NodeJS. The current decentraland node requires NodeJS v7.4.0 or higher. See nvm for version management.

stefek99 commented 7 years ago

Of course I read the README and of course I know that newer version of node is required.

That is why I said:

my work machine with old node

No worries, the .iso download is completed, I can try to reproduce the issue.