coveralls
commented
2 years ago Pull Request Test Coverage Report for Build 2023768709
- 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 84.854%
| Totals | |
|---|---|
| Change from base Build 2017049950: | 0.0% |
| Covered Lines: | 326 |
| Relevant Lines: | 371 |
What ?
Remove dcl-catalyst-client dep and use @dcl/hash instead
Why ?
When we try to install @dcl/buidler-client on our linker dapp (CRA app), it fails because dcl-catalyst-common dependency uses a tsconfig target 2020 (i.e. non-nullish operator ??) and with webpack 4 we can't use them in a easy way.
So in order to be able to use this module there are multiple options. (IMO) Update the dcl-catalyst-commons to the latest version which targets to ES2018, or use @dcl/hashing instead of dcl-catalyst-common hashing fn that are deprecated, or update our cra version to react-scripts v5 ( I already tried this and its almost rewrite the entire app).
This PR goes with the @dcl/hash alternative but its up to you what to choose. Any option will be ok for us, thanks in advance :)