decentraland / builder-server

Builder app backend
20 stars 17 forks source link

feat: Remove rarities with oracle FF #572

Closed fzavalia closed 2 years ago

fzavalia commented 2 years ago

Closes #522

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2755566294


Files with Coverage Reduction New Missed Lines %
src/ethereum/api/peer.ts 4 45.83%
src/Collection/Collection.service.ts 5 92.59%
<!-- Total: 9 -->
Totals Coverage Status
Change from base Build 2699856506: -0.08%
Covered Lines: 2577
Relevant Lines: 3609

💛 - Coveralls
fzavalia commented 2 years ago

@LautaroPetaccio Reverted the suggestion because that function is being called multiple times and using "Once" will just mock it 1 time.

It is cleared on the root before each so it will not cause any problems.

Changed it to mockRejectedValue instead of the previous mockImplementation still.