search

decentraland / creator-hub

MIT License
0 stars 4 forks source link

castShadows property not working #189

Open nearnshaw opened 1 year ago

nearnshaw commented 1 year ago

The castShadows property in a material doesn't affect the rendering of the entities. It always casts a shadow, with or without it

example:

https://playground.decentraland.org/?code=CmNvbnN0IG1lc2hFbnRpdHkgPSBlbmdpbmUuYWRkRW50aXR5KCkKVHJhbnNmb3JtLmNyZWF0ZShtZXNoRW50aXR5LCB7IAogIHBvc2l0aW9uOiBWZWN0b3IzLmNyZWF0ZSg0LCAzLjUsIDQpLApzY2FsZTogVmVjdG9yMy5jcmVhdGUoNCwgNCwgNCkgfSkKCgpNZXNoQ29sbGlkZXIuc2V0Qm94KG1lc2hFbnRpdHkpCk1lc2hSZW5kZXJlci5zZXRCb3gobWVzaEVudGl0eSkKCmNvbnN0IHRleHR1cmVTb3VyY2U6IEdlbmVzaXNQbGF6YUNvbnRlbnQgPSAnaW1hZ2VzL3BvcnRyYWl0cy9iZXR0eS5wbmcnCk1hdGVyaWFsLnNldFBick1hdGVyaWFsKG1lc2hFbnRpdHksIHsKICAgIHRleHR1cmU6IHsKICAgICAgIHRleDogewogICAgICAgICAkY2FzZTogInRleHR1cmUiLAogICAgICAgICB0ZXh0dXJlOiB7CiAgICAgICAgICAgIHNyYyA6IHRleHR1cmVTb3VyY2UsCiAgICAgICAgICAgIHdyYXBNb2RlOiAwCiAgICAgICAgIH0KICAgICAgIH0KICB9LAogIGNhc3RTaGFkb3dzOiBmYWxzZSwKICBhbGJlZG9Db2xvcjogIHtyOiAxLCBnOjAuNSwgYjogMC41fSwKfSApCgo%3D

0xD-Fabio commented 1 year ago

Fixed part of the bug on the SDK7 in this PR. Working on this issue, we found out that the SDK7 rendereable are not been culled and we opened an issue.