search

decentraland / creator-hub

MIT License
1 stars 4 forks source link

castShadows property not working #189

Open nearnshaw opened 1 year ago

nearnshaw commented 1 year ago

In PBR materials, the CastShadows property works as expected. But it doesn't in basic materials.

The castShadows property in a basic material doesn't affect the rendering of other entities. It never casts any shadow. If castShadows is true, I should see shadows on other entities. Even though the material of the entity is unlit, it should be able to affect the lighting of other entities.

Otherwise we should mark the castShadows property as deprecated and remove it from the Creator Hub UI for Basic materials.

PBR with castShadow Image

PBR without castShadow Image

Basic is the same with or without castShadow Image

0xD-Fabio commented 1 year ago

Fixed part of the bug on the SDK7 in this PR. Working on this issue, we found out that the SDK7 rendereable are not been culled and we opened an issue.