decentraland / creator-hub

MIT License
0 stars 4 forks source link

Out of bounds warnings for alpha #203

Open nearnshaw opened 1 month ago

nearnshaw commented 1 month ago

In the Web explorer, we check if an entity is out of bounds by checking its bounding box. So if any part of the object is outside the scene, or even if just a corner of the invisible bounding box is out of the scene, the entire 3D model is not rendered. The way we warn creators in the Scene Editor is consistent with this, if just a corner of the bounding box is out, we mark the whole model in red, and we highlight the bounding box to make clear its size.

Image

In the new Explorer Alpha, however, this behavior changes. Bounding boxes are no longer relevant. We check with the actual visible geometry of the model. And if just a corner of the model pokes out, we just slice off that little bit. So marking the whole model in red can be misleading. I might not care if a corner of the bounding box is outside, I might not care if a little branch of my tree is outside but the rest of my tree is rendered.

We need to come up with a way to signal this out of bounds behavior in the Editor canvas that is more consistent with how it behaves in Explorer Alpha.