decentraland / creator-hub

MIT License
0 stars 4 forks source link

fix: installers #33

Closed cazala closed 2 months ago

cazala commented 2 months ago

This PR disables the ASAR packaging that seems to be breaking the installers. The ASAR packaging is encouraged in production builds because it makes the app run faster using a virtual file system and avoids issues on Windows with very long paths, but we need to add binaries from within the ASAR file to the $PATH (node and npm) so we can use sdk-commands and that cannot be done if those binaries are on virtual paths. I'm disabling the ASAR packaging for now, let's investigate in the future if we could just unpack the binaries that we need and keep the rest of the app packed, instead of disabling it all together.

This PR also changes the template icons and names for real ones (might not be the final ones, but it's better than the placeholders).

I also downgraded the version of the repo from 2.0.0 to 0.1.0 since we are still under development.