search

decentraland / decentraland-eth

DEPRECATED - Ethereum common helpers for Decentraland
https://decentraland.github.io/decentraland-eth/
Apache License 2.0
15 stars 9 forks source link

feat: fail if the tx is dropped #12

Closed nicosantangelo closed 6 years ago

nicosantangelo commented 6 years ago

also removes repeated code for fetching transaction statuses.

The idea is to make waitForCompletion aware of dropped transactions, which return as null, but give it some time to wait in case there's congestion (hence the retriesOnEmpty).

I'm not in love with the impl, comments are welcomed

menduz commented 6 years ago

nicosantangelo commented 6 years ago

Let me rebase and squash so it looks cleaner!

Edit: Done!