search

decentraland / decentraland-eth

DEPRECATED - Ethereum common helpers for Decentraland
https://decentraland.github.io/decentraland-eth/
Apache License 2.0
15 stars 9 forks source link

feat: fix sha3 signature. add the non-deprecated keccak #15

Closed nicosantangelo closed 6 years ago

menduz commented 6 years ago

is there a difference between them? why do we create proxy functions instead of accessing them directly?

nicosantangelo commented 6 years ago

They're not exactly the same, SHA3 is obsolete and is Keccak is the preferred version. I created both just to follow the implementation ethereumjs-util, we can leave only keccak.

If by accessing them directly you mean exposing ethereumjs-utils methods and calling them instead of adding our own, it was just a matter of not polluting eth.utils but I'm all for it, although I'm not sure about the API. Also, we might want to add https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/ethereumjs-util as a dependency.