search

decentraland / decentraland-eth

DEPRECATED - Ethereum common helpers for Decentraland
https://decentraland.github.io/decentraland-eth/
Apache License 2.0
15 stars 9 forks source link

feat: override getPendingAmount to view #16

Closed nachomazzara closed 6 years ago

nachomazzara commented 6 years ago

At NanoLoanEngine Ripio contract there is a contract method we need to call in order to get the loan's outstanding amount. As the method is not a view cause change the contract state, we need to make a workaround changing the ABI until we decide to make the interest math on our side

menduz commented 6 years ago

Are you planning to execute that method as a view? that won’t work, did you test it? On Sun, 10 Jun 2018 at 11:12 Ignacio Mazzara notifications@github.com wrote:

@nachomazzara https://github.com/nachomazzara requested your review on: decentraland/decentraland-eth#16 https://github.com/decentraland/decentraland-eth/pull/16 feat: override getPendingAmount to view.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/decentraland/decentraland-eth/pull/16#event-1672640969, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP4EmpSWcKSwdTP6l_Am6DPDajtiLxPks5t7SlVgaJpZM4Uhuud .

nachomazzara commented 6 years ago

Yes! I tested it and works

nachomazzara commented 6 years ago

@menduz, @NicoSantangelo told me about the way of calling the contract method as

sendCall so we don't need to override anything.

Close PR