search

decentraland / decentraland-eth

DEPRECATED - Ethereum common helpers for Decentraland
https://decentraland.github.io/decentraland-eth/
Apache License 2.0
15 stars 9 forks source link

feat: drop node-hid dependency #33

Closed eordano closed 5 years ago

eordano commented 5 years ago

Allows decentraland-eth to be run without needing node's version to be 8, and the ugly dependency on binaries that are not used.

nicosantangelo commented 5 years ago

Isn't this the same as this (somewhat) old PR? https://github.com/decentraland/decentraland-eth/pull/24

eordano commented 5 years ago

Looks like it is, but mine tries to keep the interface

nicosantangelo commented 5 years ago

Oh, ok, keep in mind that networkId needs to be an integer now and askConfirm seems to be required (didn't work without it when I coded the original PR)

cazala commented 5 years ago

Is there a reason for having the ganache-cli and web3 versions locked? Also for using a release candidate of husky?

eordano commented 5 years ago

Yes, Ganache at some point changed their API and all tests break (even though it's a minor version update from 6.1.0 to 6.1.8, the current latest). I didn't have time to bisect the exact version when it starts breaking.

I'm locking web3 to avoid npm-check-updates from looking to update it to 1.0.0 beta.

cazala commented 5 years ago

I made a release candidate decentraland-eth@5.0.1-rc1 and tested it locally and on CircleCI. The installation works with node 10 and without the libusb system dependencies.

All the tests passing but I still need to test this with an actual ledger before merging.

eordano commented 5 years ago

I'm going to sleep so much better now