decentraland / explorer

🌎 Explore Decentraland from a web browser
https://explorer.decentraland.org
Apache License 2.0
78 stars 39 forks source link

fix: Graphics setting "match 1080p" works as "unlimited" every time we start the explorer #2497

Closed sandrade-dcl closed 3 years ago

sandrade-dcl commented 3 years ago

What does this PR change?

Fix decentraland/unity-renderer/issues/817

In macOS when we have the "match 1080p" graphics resolution setting saved in the settings panel, every time we start the explorer, it works as "unlimited", thus trying to reach max resolution which is 3072 x 1920 in retina display, greatly decreasing performance.

If I manually change the resolution setting to another setting and come back to 1080, it starts working fine again.

The canvas resolution can be checked in the dev tools, at the Elements tab, looking at the attributes of the Canvas, child of the GameContainer element:

Screen Shot 2021-07-20 at 03.06.12.png

Test link

https://play.decentraland.zone/branch/fix/Graphics-setting-match-1080p-works-as-unlimited-every-time-we-start-the-explorer/index.html?ENV=org

github-actions[bot] commented 3 years ago

After the CI passes: