search

decentraland / kernel

Kernel is the glue code between the OS, comms and the Renderer of Decentraland
https://play.decentraland.org
Apache License 2.0
19 stars 24 forks source link

Extend `WearablesRequest` to support Third Party collection wearables #257

Closed guidota closed 2 years ago

guidota commented 2 years ago

Description

In order to support Third Party Wearables (or Linked Wearables) in the backpack, we need to add a query parameter to the Wearables request.

Catalyst Lambdas service will add an optional collectionId query param to /wearables-by-owner endpoint: /wearables-by-owner/:owner?collectionId={string}

menduz commented 2 years ago

where does the collectionId comes from? is it available today in kernel? Isn't this something related to backpack and the renderer?

guidota commented 2 years ago

As I understand, in order to build the backpack the Explorer creates this request to the Kernel called WearablesRequest, which ends up calling the Lambdas endpoint wearables-by-owner.

In case of TPW there is an extra collectionId query param to be included in the request.

I will submit a PR with this change soon.

Edit:

there is more detailed info in this PRD about backpack integration: https://www.notion.so/decentraland/PRD-Third-Party-Assets-Option-D-4ddc235718ec456ea79a59d0c23f3d70#60006fdb60eb4b3b92b0bb2400b6cc41

menduz commented 2 years ago

Should this value come from unity? If that's the case, I assume we also need to summon @olavra