search

decentraland / proposals

Review of community proposals for Decentraland's art and applications
46 stars 16 forks source link

Proposal - Escrow contract for swapping land #139

Open silkwebware opened 6 years ago

silkwebware commented 6 years ago

Proposal : Escrow contract for swapping land. Two parties enter into contract to swap land. Arbitrator considers terms in a conflict occurs and has control over final outcome. Arbitrator(s) take a fee if called upon.

silkwebware commented 6 years ago

Important for straight after main auction. Allows buyers to consolidate their holdings via a barter like fast moving swap. Avoid slow moving subsequent auctions. Example : A user may swap site 'A' for another user's site 'B' & 'C'

PositiveControl commented 5 years ago

@silkwebware Unrelated to this proposal, I spiked out an escrow contract (a Discord community member was ripped off by someone). As of now, it's a total spike, no tests, missing functionality (i.e. ERC721 token validation, trading of multiple tokens, mixed payment - ERC721+ERC20, etc).

That said, I hope it can provide for a jumping off point, and I'd love to contribute! Even though I'm a pretty green Solidity dev.

@eordano after spiking this contract (https://github.com/PositiveControl/land/blob/feat/escrow/contracts/utils/Escrow.sol) I found a comment left today stating that this is already in progress (https://github.com/decentraland/marketplace/issues/800). I looked through the repo branches, but didn't see anything active related to Escrow. Any chance a n00b contributor (me) can assist in this? I'm recently active in the market-side of things and would like to contribute more on the dev side as I plan to build out my own DCL LAND/Estate.

Cheers,

Chuck d'Gaf#7476 (on discord)

eordano commented 5 years ago

Thanks @PositiveControl!

We usually start working on private repositories to avoid silly mistakes or noisy signals coming out of the team. I just open sourced the contract:

https://github.com/decentraland/bid-contract

The idea is to do an on-chain bid on a parcel, so that users could see a notification list of all the offers they received, and take them if they want.