decentraland / unity-explorer

Apache License 2.0
9 stars 11 forks source link

[QA] Alpha mask not applied to extra screens in 'NicoE' World #1691

Closed Ludmilafantaniella closed 1 week ago

Ludmilafantaniella commented 3 months ago

Explorer Alpha build versions:

Issue Description:

In the 'NicoE' World, extra screens that were added with a circular alpha mask are not displaying as intended. The alpha mask is not being applied, resulting in the screens showing the full display instead of the expected circular cutout.

STR:

  1. Launch the explorer
  2. Enter /world NicoE command on the chat
  3. Locate the extra screens with the intended circular alpha mask.
  4. Observe how the screens are displayed.

Expected behavior:

Screenshot 2024-08-07 at 4 30 17 PM

Current behavior:

image

Additional Notes:

Windows 11. 12th Gen Intel(R) Core(TM) i7-12650H 2.30 GHz. nvidia geforce RTX

QThund commented 2 months ago

Currently, the generic material that we use for most of the objects in the scene is not using the alpha texture that is being set in the code. The shader has to be expanded to support this feature as it did in the old version.

GBirch33 commented 2 months ago

Problem with this solution is now we've got a shader which has both an alpha channel in the albedo/diffuse texture which applies alpha and also a totally separate 4 channel texture for alpha, when in reality this shader is already setup for what you need. If a material which was being use on old renderer has an alpha mask texture then copy across the alpha values in said texture into the alpha channel of the albedo/diffuse texture. We'd probably need to do this in the Asset Bundle converter really. Unless I'm missing something?

QThund commented 2 months ago

It's an "animated" texture, they use AVProvideo to fill it every frame, I don't know how does it work.

GBirch33 commented 1 month ago

Agreed with Artists to shift the AlphaMask Texture to an Unlit Shader, along with 'Receives Shadows Off' flag.

AlejandroAlvarezMelucciDCL commented 1 week ago

@QThund I had this issue assigned to me but I assigned to you since you already addressed the fix here https://github.com/decentraland/unity-shared-dependencies/pull/38 (Good job btw!)

GBirch33 commented 1 week ago

The work for this is complete, shader created and SDK fixed up to match.