decentraland / unity-explorer

Apache License 2.0
9 stars 11 forks source link

[QA] Clipping issues with some wearables #2300

Open DafGreco opened 1 month ago

DafGreco commented 1 month ago

Explorer Alpha build versions:

0.29.0

Issue Description:

There are some wearables that cannot be completely seen by the user when using them

STR:

  1. Open 0.29.0
  2. Go to the backpack
  3. Change outfits
  4. Validate that the outfit cannot be completely seen by the user

Expected behavior:

The clothes should be able to be seen properly by the user when changing them on the backpack

Current behavior:

There are some wearables that cannot be completely seen by the user when using them

Evidence:

image (5) image (6) image (4)

Additional Notes:

Happens on Windows 11 PRO 16 GB RAM

Ludmilafantaniella commented 1 month ago

It appears that when a user has a wearable that hides another (like a wearable hiding the helmet), and then they unhide the helmet, both wearables overlap. This could be causing visual issues that need addressing.

1770 : I think these two tickets are the same!

anicalbano commented 1 month ago

This might be related, but the following wearable: https://decentraland.org/marketplace/contracts/0x642615cc0f4abd6487be1e03e6fd69adbf7f553f/items/0 also has an issue with the view. Seems like in world there is only one wing visible but if you look at the wearable from one side, you can see both of them:

image image

ShibuyaMartin commented 4 weeks ago

can we have the glbs to check them? it seems is due to the backface culling

ShibuyaMartin commented 4 weeks ago

https://docs.decentraland.org/creator/wearables/creating-wearables/#normals --> check this for more info but we allow only one side render

ShibuyaMartin commented 4 weeks ago

if you point me the links on the marketplace i can also download them from the servers @DafGreco

Kaze-No-Kai commented 4 weeks ago

Another issue most likely related to clipping: https://decentraland.org/marketplace/contracts/0xa475aa972fc7b5164f80ea4d5534313f4a584230/items/0 Screenshot_2024-10-29_053232

Kaze-No-Kai commented 3 weeks ago

Another example of a wearable with a possible clipping issue: https://decentraland.org/marketplace/contracts/0x222deaa90399023e707abd3f81b268493bdc891a/items/2

![Uploading (Stevame) cigar wearable doesn't work.png…]()

Kaze-No-Kai commented 3 weeks ago

hey @ShibuyaMartin regarding the 1 side render, is this related to this wearable? https://decentraland.org/marketplace/contracts/0x642615cc0f4abd6487be1e03e6fd69adbf7f553f/items/0 I am asking as it works fine on the old client, but not on the new one?

GBirch33 commented 19 hours ago

@Kaze-No-Kai Yes it probably is. Do we have the ability to contact the artist and ask to remake using back face culling only? The reason is that back-face culling is all we support due to performance cost of state change and therefore affects on batching. Basically clone the double sided mesh and invert the normals, then it should be right.

Kaze-No-Kai commented 2 hours ago

@GBirch33 for the wing one right? Is the backface culling only also related to the clipping issue that is in the first comment? Also i understand that this is for performance optimization, but is this something we introduced with the new client or it was always a requirement for creators?