decentraland / unity-explorer

Apache License 2.0
8 stars 11 forks source link

[QA] Minigames - Salad Slash Lacks Colliders for Active Gameplay #2413

Closed Ludmilafantaniella closed 1 week ago

Ludmilafantaniella commented 2 weeks ago

Explorer Alpha build versions:

Issue Description:

The Salad Slash minigame (17,-114) does not have colliders to separate the ongoing game from other users in the queue. This absence leads to interference, as players can pass through the screen and disrupt the active gameplay, unlike the behavior observed in other game challenges.

STR:

  1. Navigate to the Salad Slash minigame at coordinates (17,-114).
  2. Start a game session.
  3. Observe that other users can move through the gameplay area, causing disruptions.

❌ Actual Result

Users in the queue can traverse the active gameplay area, interfering with the current game session.

✅ Expected Result

Colliders should be present to prevent users from entering the gameplay area during an active session, ensuring uninterrupted gameplay.

Evidence:

https://github.com/user-attachments/assets/f6168dc8-025f-4de5-83eb-453e8d6e294d

Additional Notes:

Windows 11. 12th Gen Intel(R) Core(TM) i7-12650H 2.30 GHz. nvidia geforce RTX Macbook M1 Pro Sonoma 14.5

dzsunyec commented 1 week ago

To address this issue I have added an AvatarModifierArea which appears when the player starts a game and hides everyone in the game area, the players's own avatar excluded

Ludmilafantaniella commented 1 week ago

@dzsunyec hey I was able to repro on v0.36.0

https://github.com/user-attachments/assets/0488868f-44a6-4b35-8863-deec9991ef80

dzsunyec commented 1 week ago

Oh, this probably means that adding the hideAvatarArea after someone walked into that area, might not affect the players already inside :( . Ok I guess I'll have to hide everyone there all the time.

Ludmilafantaniella commented 1 week ago

🟢 Fix verified on both Mac and windows. Colliders are present and prevent users from entering the gameplay area during an active session, ensuring uninterrupted gameplay.

https://github.com/user-attachments/assets/f9773423-9a7e-4cf8-b133-6121614f226e