decentraland / unity-explorer

Apache License 2.0
9 stars 11 forks source link

[QA] Performance | Backpack slots disappear or stay in loading animation in crowded scenes #2538

Open Ludmilafantaniella opened 1 month ago

Ludmilafantaniella commented 1 month ago

Explorer Alpha build versions:

Issue Description:

When staying for a long time in a scene with approximately 40 avatars, opening the backpack (press [I]) either causes the slots to completely disappear or stay in the loading animation indefinitely.

STR:

  1. Enter a scene with around 40 avatars.
  2. Stay in the scene for an extended period of time.
  3. Open the backpack by pressing [I].
  4. Observe if wearables and emote slots load correctly.

❌ Actual Result

✅ Expected Result

Evidence & LOGS:

LOGS: Player.zip

image

https://github.com/user-attachments/assets/744ef0a9-78d0-45f2-adc4-75160fb42b04

Additional Notes:

Windows 11. 12th Gen Intel(R) Core(TM) i7-12650H 2.30 GHz. nvidia geforce RTX Macbook M1 Pro Sonoma 14.5

lorux0 commented 1 month ago

Seems to be a problem with budgeting, specially memory budgeting, at least testing it on editor. The budgeting blocks all the intentions so then nothing loads: https://github.com/decentraland/unity-explorer/blob/278ba86a32615ecbd896de1c1ac69829a5fb5958/Explorer/Assets/Scripts/ECS/StreamableLoading/DeferredLoading/DeferredLoadingSystem.cs#L81 This is only the point of the iceberg and changing it is not trivial, and would require a consensus on how to handle this situations, since memory management affects everything in the application

Kaze-No-Kai commented 3 weeks ago

Testing in-world with the /debug . If i click on Memory FULL, i get this repro 100%. Most likely indeed memory related

Vitsky4079 commented 1 week ago

Sharing another example from a user: https://drive.google.com/file/d/1sBxClyQ2tyYphKGzq-T6njyRN1Ia-abZ/view?usp=sharing

Logs: Player.log (4).zip