decentraland / unity-renderer

Unity implementation of Decentraland Client
https://play.decentraland.org
Apache License 2.0
137 stars 93 forks source link

Exception: Promise is forgotten #4277

Closed mikhail-dcl closed 1 year ago

mikhail-dcl commented 1 year ago

Sentry Query

it looks like this exception is non-actionable. Review this branch

private IEnumerator ForceFailPromiseList(List<AssetPromiseType> promises)
        {
            int promisesCount = promises.Count;

            for (int i = 0; i < promisesCount; i++)
            {
                var promise = promises[i];
                if (promise.isForgotten)
                    continue;

                promise.ForceFail(new Exception("Promise is forgotten"));
                Forget(promise);
                CleanPromise(promise);

                IEnumerator enumerator = SkipFrameIfOverBudget();

                if (enumerator != null)
                    yield return enumerator;
            }
        }

and decide on what to do with promises that were not resolved and blocked

PalauiDCL commented 1 year ago

A new task for the refactor of this system has been created: #4389