search

decentraland / unity-renderer

Unity implementation of Decentraland Client
https://play.decentraland.org
Apache License 2.0
137 stars 93 forks source link

Asset bundles breaking animation #5025

Closed decentraland-bot closed 1 year ago

decentraland-bot commented 1 year ago

Severity:

SEV-4 | Minor issue

Description:

A scene has some pretty elaborate animations, that work fine in preview but not on the deployed scene once converted to asset bundles

Operating system:

NA

Error:

null

Browser (version):

NA

Ticket number:

NA

viktorfx commented 1 year ago

I also encountered this issue. I tried the asset bundles in Unity editor and it works there but it doesn't in browsers. I can provide the model with the broken animations. Can please someone look at this issue?

viktorfx commented 1 year ago

I was able to resolve it. For anyone having the same problem, check the names of your model animations if they don't contain some special characters (e.g. |), because after conversion to asset bundles, such characters are replaced by _.

dalkia commented 1 year ago

Hey @viktorfx! Would you mind sending me the asset previous to your fix? We dont explicitly change the name of animations in the conversion; so I want to dig deeper on whats going on

viktorfx commented 1 year ago

Hey @dalkia, you can download it here. If you need more info, let me know.

dalkia commented 1 year ago

Thank you so much @viktorfx .

Please bare with me, Im out on vacation till July, when I come back I ll give it a look.

dalkia commented 1 year ago

Hey @viktorfx ! Sorry for the delayed answered.

We will be changing how we build the asset bundles to the Scriptable Build Pipeline. I was not able to reproduce the issue using the SBP. I'll keep the naming issue in mind if someone reports it again using the old build method.

Thank you for your input