search

decentraland / unity-renderer

Unity implementation of Decentraland Client
https://play.decentraland.org
Apache License 2.0
136 stars 93 forks source link

Query the WITH_COLLECTIONS param from unity #5451

Closed dalkia closed 12 months ago

dalkia commented 1 year ago

Since we moved the emotes and wearables request to Unity using the lambdas, we lost the ability to query the WITH_COLLECTIONS param.

Currently, the WITH_COLLECTIONS param only work when going through kernel. When the param is present, kernel fetches the entities of the collection and then forces them into the response that is sent back to Unity. Therefore, if the request does not go through kernel, the param does not work. Since we want to stop supporting kernel, we should properly implement this functionality in Unity.

Some suggested steps would be:

1) Inject the param from kernel into Unity (The kernelConfig could be use for this) 2) Fetch the collections (Kernel uses the endpoint https://builder-api.decentraland.org/v1/collections/${collectionUuid}/items to fetch them) 3) Add the resultant urns to the wearable and emotes request, respectively

aixaCode commented 1 year ago

https://github.com/decentraland/unity-renderer/issues/5401

lorux0 commented 1 year ago

In order to be able to preview wearables/emotes from builder the WITH_ITEMS has been implemented as well

lorux0 commented 1 year ago

Blocked until dapps implements the auth chain signing with timestamp.{metadata} https://decentralandteam.slack.com/archives/C022B026W1F/p1693245868306279

lorux0 commented 1 year ago

PR: https://github.com/decentraland/unity-renderer/pull/5652