decentraland / unity-renderer

Unity implementation of Decentraland Client
https://play.decentraland.org
Apache License 2.0
136 stars 94 forks source link

fix: remove avatar attach offset in character controller #6190

Open aixaCode opened 2 months ago

aixaCode commented 2 months ago

What does this PR change?

Removes 0.75 offset in the avatar attach component.

After this is merge, we can merge back those changes https://github.com/decentraland/sdk7-goerli-plaza/pull/167 This is the expected result: Screenshot 2024-04-30 124929

This can introduce breaking change for some scenes. With current live version the test scene will be broken and look like that

Screenshot 2024-04-30 125555

How to test the changes?

  1. Launch the explorer
  2. /changerealm https://sdk-team-cdn.decentraland.org/ipfs/goerli-plaza-fix-protocol-squad-1-latest
  3. Go to 75,-7
  4. check that the switched avatar model is aligned properly on the ground

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

github-actions[bot] commented 2 months ago

After the CI passes:

Web

This branch can be previewed at:

Desktop:

If you have the launcher installed (download launcher) you can press open on the following link:

SDK 7

SDK 6

More