decentraland / unity-renderer

Unity implementation of Decentraland Client
https://play.decentraland.org
Apache License 2.0
137 stars 93 forks source link

fix: duplicated ids on video streaming #6222

Closed lorux0 closed 3 months ago

lorux0 commented 3 months ago

What does this PR change?

In areas with numerous scenes, each containing video streams, there was a risk of duplicated IDs because only the entityId was used as the identifier for the videos.

The solution involves appending the scene number to the video streaming ID to ensure uniqueness.

How to test the changes?

  1. Launch the explorer
  2. Goto -1,89
  3. Check that the video streaming of the scene is working
  4. Walk around the event
  5. Check that all of the video streamings are working

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

github-actions[bot] commented 3 months ago

After the CI passes:

Web

This branch can be previewed at:

Desktop:

If you have the launcher installed (download launcher) you can press open on the following link:

SDK 7

SDK 6

More