decentraland / unity-renderer

Unity implementation of Decentraland Client
https://play.decentraland.org
Apache License 2.0
137 stars 93 forks source link

chore: re introduce uitext wrapping #6228

Closed AlejandroAlvarezMelucciDCL closed 3 months ago

AlejandroAlvarezMelucciDCL commented 3 months ago

Re-introduced ui text wrap with no-wrap as the default behavior

How to test the changes?

  1. Use the following url: PLAYGROUND A

  2. On the URL, note that it contains explorer-branch=chore%2Fre-introduce-uitext-wrapping which means the Playground is using this branch. Then the URL follows with &code=, note there's no mention of the SDK. This would be the case where an OLD scene is loaded: Label 1, doesn't have the property => text is not wrapped Label 2, does have the property, with the value nowrap => text is not wrapped Label 3, does have the property, with the value wrap => text is wrapped image On the left we can see the code for the 3 labels.

  3. Use the following url: PLAYGROUND B

  4. On the URL, note that it contains explorer-branch=chore%2Fre-introduce-uitext-wrapping which means the Playground is using this branch. Then the URL follows with ?sdk-branch=chore%2Fre-introduce-uitext-wrapping which means the Playground is using the SDK version with the new default behavior for wrapping text. This would be the case where a new scene is created: Label 1, doesn't have the property => text is wrapped Label 2, does have the property, with the value nowrap => text is not wrapped Label 3, does have the property, with the value wrap => text is wrapped image On the left we can see the code for the 3 labels.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

github-actions[bot] commented 3 months ago

After the CI passes:

Web

This branch can be previewed at:

Desktop:

If you have the launcher installed (download launcher) you can press open on the following link:

SDK 7

SDK 6

More