search

decentraland / vesting-dashboard

📈 Decentraland's vesting dashboard
https://vesting.decentraland.org
2 stars 8 forks source link

Feat/wrong network modal #72

Closed 1emu closed 1 year ago

1emu commented 1 year ago

No contract address given

image

Viewing a contract and switching networks

image

Signed out, Metamask in Mainnet

image

Signed out, wrong Metamask Network

image

Logged in, unknown Network

image

cazala commented 1 year ago

And I just wanted to left another side note: I noticed that this dapp is using thunks instead of sagas, but we do have already lots of functionality builit on decentraland-dapps redux modules, which might come in handy. Like handling different providers (like wallet connect, fortmatic, coinbase wallet) and it already handles the logic of switching networks or stopping the user if they are in the wrong network. Also once single sign on is finished it would be supported there. At some point it might be worth considering reusing those modules instead of re-writing everything as thunks, specially considering there are only 5 thunks on this app, so migrating those to sagas is trivial.