Rename principle-did - Githubissues

decentralised-dataexchange / automated-data-agreements

This repository contains the specifications for Automated Data Agreement (ADA) Project. The project is part of NGI-eSSIF-Lab that has received funding from the European Union’s Horizon 2020 research and innovation programme under grant agreement No 871932

Apache License 2.0

11 stars 6 forks source link

Rename principle-did #18

Closed JanLin closed 2 years ago

JanLin commented 2 years ago

Please rename "principle-did" to "data-subject-did" which aligns better with DID Method actors? Principle was a term used in ISO, "pii_principle" and nowhere is it used.

georgepadayatti commented 2 years ago

@lalc Is this ok ?

lalc commented 2 years ago

Yes.

To update the following:

[ ] DA JSON schema
[x] DA JSON-LD
[ ] The DA vocab

georgepadayatti commented 2 years ago

and

[x] DA Plugin (ACA-Py)

The changes from now on, are going to have considerable impact.

JanLin commented 2 years ago

Just realized all field names use "_" (underscore) and not "-" (dash). Is it too late to make it "data_subject_did"?

georgepadayatti commented 2 years ago

and

[x] DA Plugin (ACA-Py)

The changes from now on, are going to have considerable impact.

Done in DA plugin.

lalc commented 2 years ago

Is it ok to close this? @georgejpadayatti