search

decentralized-identity / DIDComm-js

JS implementation of pack and unpack
Apache License 2.0
55 stars 25 forks source link

fix: Incorrect Base64URL encoding used #24

Open kg0r0 opened 4 years ago

kg0r0 commented 4 years ago

Fixed https://github.com/decentralized-identity/DIDComm-js/issues/21

kdenhartog commented 4 years ago

just noting, I'll bring this up on the next DID-Auth call, so we can get this through ASAP without breaking anyone. When this was discussed in the Aries WG, we recognized it was a breaking change but accepted "everyone" (that we know of at least) would move in that direction. The one who I'm thinking may depend on this package is uPort which is why I want to make sure they have someone aware of this.

kg0r0 commented 4 years ago

Thank you for your reply. I will add a commit to resolve the conflicts.

awoie commented 4 years ago

@awoie who's the best one at uPort to look at this and make sure it won't break anything for you guys?

From our end @mirceanis will be mostly involved in everything that is related to the DIDComm implementation. We should be fine with this PR but let's discuss on the next DID Auth Call.

kg0r0 commented 3 years ago

@awoie @kdenhartog Hi! What is the status of the confirmation?