Update Spruce implementation for ES384

decentralized-identity / JWS-Test-Suite

JsonWebSignature2020 Test Suite

https://identity.foundation/JWS-Test-Suite

Apache License 2.0

9 stars 11 forks source link

Update Spruce implementation for ES384 #60

Closed clehner closed 2 years ago

clehner commented 2 years ago

Integrates https://github.com/spruceid/ssi/pull/431 to add ES384 support in Spruce's (ssi) implementation.

Also update to handle API changes made in https://github.com/spruceid/ssi/pull/432.

clehner commented 2 years ago

@decentralgabe @OR13 With this change, we should be able to show two independent implementations (TBD's and Spruce's) passing the complete test suite (the five JWS algorithms; DI & JWT; VC & VP; all test vector payloads). If Transmute added RSA, we'd have three.

OR13 commented 2 years ago

in case this sits, feel free to merge

clehner commented 2 years ago

Thanks!

clehner commented 2 years ago

Well, ES384 succeeded (https://github.com/decentralized-identity/JWS-Test-Suite/runs/6599718261 - 8be234d31ea631d634e672defb1fa67ca501e402) but now there is a failure in RSA VP-JWT (presentation-2). Probably because of some change in the ssi library. I'll look into that. Edit: fixed: https://github.com/decentralized-identity/JWS-Test-Suite/pull/62#issuecomment-1143897852