search

decentralized-identity / bbs-signature

The BBS Signature Scheme
https://identity.foundation/bbs-signature/draft-irtf-cfrg-bbs-signatures.html
Apache License 2.0
79 stars 26 forks source link

Fix Blind Messages Proof #134

Open alessandroguggino opened 2 years ago

alessandroguggino commented 2 years ago

I found something new from the Blind signature extension. I know that you are now focused on the core draft but I leave it here :)

In BlindMessagesProofGen: https://github.com/decentralized-identity/bbs-signature/blob/5fba426d415b85b6156a0c001e605482bdf3b770/draft-blind-bbs-signatures.md?plain=1#L249 In BlindMessagesProofVerify: https://github.com/decentralized-identity/bbs-signature/blob/5fba426d415b85b6156a0c001e605482bdf3b770/draft-blind-bbs-signatures.md?plain=1#L284

The values in c and cv are inconsistent: we should decide which one to follow. 1) c = hash(U || U~ || nonce) and cv = hash(U || U^ || nonce) + add U (known messages) as input parameter in BlindMessagesProofVerify or 2) c = hash(commitment || U~ || nonce) and cv = hash(commitment || U^ || nonce)

P.S. I'm going to open a pull request to remove the unuseful escape chars and, if you want, update the draft to snake_case notation

tplooker commented 2 years ago

Hey @alessandroguggino good catch, yes there are some inconsistencies, however you are right that our focus as a WG is primarily on the core draft right now. Feel free to open a PR to address any syntax inconsistencies anything broader we will address once the core draft is complete/stable.