search

decentralized-identity / bbs-signature

The BBS Signature Scheme
https://identity.foundation/bbs-signature/draft-irtf-cfrg-bbs-signatures.html
Apache License 2.0
78 stars 26 forks source link

Consistency updates #192

Closed BasileiosKal closed 2 years ago

BasileiosKal commented 2 years ago

Changes for consistency:

  1. len() -> length().
  2. Consistent array de-structuring.
  3. Make code blocks < 72 chars.
  4. Update create_generators. Same result, removed the while and added a go back to step 4 for consistency (we where referencing generator_0 without defining it at the first step where i = 1).
BasileiosKal commented 2 years ago

Discussed on the WG call. The issue of the naming convention for SK and PKs came up (neither the SK not the PK is a point to be capitalized). Will address to another PR to avoid conflicts with #186.

tplooker commented 2 years ago

Multiple approvals, purely editorial, merging