search

decentralized-identity / bbs-signature

The BBS Signature Scheme
https://identity.foundation/bbs-signature/draft-irtf-cfrg-bbs-signatures.html
Apache License 2.0
79 stars 26 forks source link

Encode for hash update #230

Closed BasileiosKal closed 1 year ago

BasileiosKal commented 1 year ago

Fixes #225

  1. Updated encode_for_hash per @andrewwhitehead's proposal from here (including renaming the operation to serialize and definING SignatureToOctets and ProofToOctets based on serialize).
  2. Added 2 new operations, get_domain and get_challenge. Their purpose is to simplify the core operations, since with the revision on encode_for_hash they would have become more complex (note proofGen will be 32 steps instead of 24 without those 2 operations).

NOTE: I would like to introduce a breaking change and put the PK at the end of the serialized array in get_domain (step 7), to be consistent with the “octet strings go at the end rule”. Not worth it now, but maybe will bundle it together with some other breaking changes at some point.

Not sure if the result is simpler overall but is more rigorous and much better defined IMO.

BasileiosKal commented 1 year ago

Discussed on the WG call 9th of January. Multiple approvals. Merging. Thank you everyone!