Reduce hash_to_scalar to a single output

decentralized-identity / bbs-signature

The BBS Signature Scheme

https://identity.foundation/bbs-signature/draft-irtf-cfrg-bbs-signatures.html

Apache License 2.0

80 stars 26 forks source link

Reduce hash_to_scalar to a single output #243

Closed andrewwhitehead closed 1 year ago

andrewwhitehead commented 1 year ago

Resolves #242

Requires some updates to test vectors.

BasileiosKal commented 1 year ago

Discussed on WG call on the 14th of Feb. Will use expand_message to address comment and discuss again in the next WG call.

BasileiosKal commented 1 year ago

Some small nits. LGTM otherwise. It complicates Sign a bit more than i would like TBH, but given that we will probably remove s eventually, i think this is the better approach (removing s will significantly simplify Sign again).

tplooker commented 1 year ago

Multiple reviews and approvals, discussed on prior WG calls, merging.