decentralized-identity / bbs-signature

The BBS Signature Scheme
https://identity.foundation/bbs-signature/draft-irtf-cfrg-bbs-signatures.html
Apache License 2.0
78 stars 26 forks source link

Error handling #267

Closed BasileiosKal closed 1 year ago

BasileiosKal commented 1 year ago

Implicitly handle errors form the utility sub-routines in the core operations + address point B from #246

BasileiosKal commented 1 year ago

Updated the PR with the following

IMO this gives the more readable result.

BasileiosKal commented 1 year ago

Breaking Changes

  1. In hash_to_scalar removed the counter
  2. In create_generators step 3, changed I2OSP(i, 4) to I2OSP(i, 8)

("1." is because I removed the checks for 0 and "2." is to align the max number of messages with the max number of generators)

tplooker commented 1 year ago

Ready for merge, subject to resolving the conflicts.