search

decentralized-identity / bbs-signature

The BBS Signature Scheme
https://identity.foundation/bbs-signature/draft-irtf-cfrg-bbs-signatures.html
Apache License 2.0
79 stars 26 forks source link

Serialize returns INVALID #295

Closed rolfhaenni closed 11 months ago

rolfhaenni commented 1 year ago

The serialize() algorithm in Section 4.2.4.1 does not include the case where an element of the input array is a string. However, exactly this happens in Lines 4 of coreSign(), where the string comm passed as input value to serialize(). Therefore, currently serialize() would return the value INVALID. Besides, the commitment is missing in Line 2 of CoreVerify().

BasileiosKal commented 11 months ago

This is absolutely correct! Resolved by PR 297. The commitment value is removed since it did not seem to serve much its original purpose, which was to support Blind BBS Signatures, now its own document.

Thank you for raising the issue! Will mark it as resolved and close it if there are no objections.

BasileiosKal commented 11 months ago

Discussed on WG call at the 18th of Dec. Closing as resolved.