decentralized-identity / bbs-signature

The BBS Signature Scheme
https://identity.foundation/bbs-signature/draft-irtf-cfrg-bbs-signatures.html
Apache License 2.0
79 stars 26 forks source link

Referencing wrong step in pseudocode #309

Closed roblesjoel closed 1 month ago

roblesjoel commented 10 months ago

In 3.6.1 CoreSign there is the note Note When computing step 12 of

but it should be Note When computing step 4 of

as there is no step 12.

In the same note at the end

Implementations MAY elect to check (SK + e) = 0 mod r prior to step 9, and or A != Identity_G1 after step 9

should be

Implementations MAY elect to check (SK + e) = 0 mod r prior to step 4, and or A != Identity_G1 after step 4