decentralized-identity / bbs-signature

The BBS Signature Scheme
https://identity.foundation/bbs-signature/draft-irtf-cfrg-bbs-signatures.html
Apache License 2.0
79 stars 26 forks source link

SecretKey KeyGen function using ciphersuiteID instead of api_id #316

Open roblesjoel opened 9 months ago

roblesjoel commented 9 months ago

In the generate secret key function (see here) only the cyphersuiteID is used for the key_dst. Instead the api_id needs to be used.

So in the definition of key_dst it should be:

Defaults to the octet string ciphersuite_id || "H2GHM2S" || "KEYGENDST" if not supplied

roblesjoel commented 9 months ago

Additional Information: The Error comes from the keypair.json fixture in the SHA folder. If "H2GHM2S" is not included the test fails as it produces a different secret key. When using api_id || "KEYGENDST" the secret key is correct.